Photocatalytic degradation is an eco-friendly and high-efficiency way to degrade dye pollutants which has broad application prospects in water pollution control. In this study, the multi-layer core-shell structure of SiO2@Ag@SiO2@TiO2 was synthesized by different methods as a photocatalyst for pollutant degradation, with oxidation-reduction method, modified Stöber method and hydrothermal method in turn. The effect of silver nitrate (AgNO3), tetraethyl orthosilicate (TEOS) and tetrabutyl titanate (TBOT) on the coating effect were discussed. The microstructure, phase structure, pore structure parameters and photoelectrical properties of SiO2-based multi-layer core-shell structure were systematically analyzed by various characterization methods and the degradation performance of methylene blue (MB) was also studied and discussed. The results show that when the mass ratio of AgNO3, TEOS and TBOT to SiO2 is 5:1, 2.4:1, and 6:1 in turn, each layer of the multi-layer cored shell structure achieves the optimal coating effect. Compared with SiO2@TiO2 and SiO2@Ag@TiO2, the core-shell structure of SiO2@Ag@SiO2@TiO2 photocatalyst has the best photocatalytic activity. The photocatalyst degradation efficiency is close to 93% with 45 min under simulated visible light irradiation, and degradation efficiency keeps at 90% after four cycles of recycling tests.