Hydrogen generation over carbon-, nitrogenand sulfur-doped TiO 2 semiconductor photocatalysts (represented as C-TiO 2 , N-TiO 2 and S-TiO 2 , respectively) under visible light irradiation has been achieved using various sacrificial electron donors, namely triethanolamine, diethanolamine, monoethanolamine, triethylamine, MeOH, EtOH, EDTA, L-ascorbic acid and phenol. The highest initial rate of H 2 production was found to be in the range 1,000-2,200 lmol/g/h at ambient conditions when triethanolamine was used as sacrificial electron donor. The efficacy of hydrogen production over these photocatalysts depends strongly on the nature of the sacrificial electron donor and decreases in the following order: C-TiO 2 [ STiO 2 [ N-TiO 2 . The results of the present studies suggest that the rate of H 2 production is not simply governed by the reduction potential of the sacrificial electron donor but also by the kinetic barrier of the electron transfer process.