Given the significant amount of public infrastructure spending and the widely expressed concern about the declining quality of the American public infrastructure system, research about the effectiveness of public infrastructure investment is especially timely and crucial. The study extends public service production theory and public choice theory to the public infrastructure field, and develops a realistic and full theoretical model of public highway production by taking state highway efficiency differences into account. The panel fixed-effects method is used to examine the effects of state highway finance on state highway infrastructure quality. This study finds that state highway maintenance spending plays a crucial role in improving state road and bridge quality. Moreover, highway efficiency elements matter for state highway infrastructure quality.