Background: While the spermatotoxic properties of cancer treatments such as chemotherapy and radiation therapy are widely recognized, the effect of malignancy itself on male fertility is not clearly understood. Objectives: To determine whether malignancy is associated with diminished semen quality prior to spermatotoxic treatment among sperm bankers. Materials and Methods: Retrospective database review of de-identified records was obtained for all episodes of sperm banking performed at a cryobank from January 2004 to May 2017 for one of the following reasons: 'future use' (e.g., military deployment and gender reassignment); infertility; benign disease; and malignancy, further categorized as testicular, other genitourinary (GU), solid non-GU, hematologic, or unspecified. Dependent variables of interest were ejaculatory volume, sperm concentration, % motility, and total motile sperm count (TMSC), as well as post-thaw TMSC. Results: A total of 1558 patients met the inclusion criteria. Multivariable regression analysis on log-transformed data controlling for age demonstrated decreased ejaculatory volume and sperm concentration, % motility, and TMSC in the infertility group as compared to the 'future use' group (p < 0.001). Testicular cancer was associated with decreased sperm concentration, TMSC, and postthaw TMSC (p < 0.001); other GU malignancy was associated with decreased ejaculatory volume (p < 0.001). Benign disease, solid non-GU malignancy, hematologic malignancy, and unspecified malignancy were not associated with decreased parameters. Discussion: In addition to sperm bankers with known fertility issues, sperm bankers with testicular and other GU malignancy had worse baseline semen parameters as compared to individuals pursuing banking for future use. These findings can inform patient counseling and consent prior to sperm banking and disease treatment. Conclusion: Individuals with testicular and other GU malignancy who banked spermatozoa before undergoing spermatotoxic therapy demonstrated worse baseline semen parameters as compared to individuals banking spermatozoa for non-medical reasons.